Skip to content

gh-135528: Support more Second-Level Domain Names in lib http.cookiejar #135529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

gh-135528: Support more Second-Level Domain Names in lib http.cookiejar #135529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a61453
Update cookiejar.py
LamentXU123 Jun 15, 2025
b504764
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 15, 2025
2f14c9e
Update Misc/NEWS.d/next/Library/2025-06-15-03-38-13.gh-issue-135528.X…
LamentXU123 Jun 15, 2025
49278e9
Update cookiejar.py
LamentXU123 Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Lib/http/cookiejar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,10 +1032,13 @@ def set_ok_domain(self, cookie, request):
if j == 0: # domain like .foo.bar
tld = domain[i+1:]
sld = domain[j+1:i]
if sld.lower() in ("co", "ac", "com", "edu", "org", "net",
"gov", "mil", "int", "aero", "biz", "cat", "coop",
"info", "jobs", "mobi", "museum", "name", "pro",
"travel", "eu") and len(tld) == 2:
known_slds = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure hard code here would be a good idea.

  1. I think known_slds should be a global variable
  2. Maybe we can allow people to customize the slds

Copy link
Member

@picnixz picnixz Jun 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already been there for a while, and it doesn't cost to have a local variable. I prefer treating customization as a separate FR (and it should rather be a class variable rather than a global one)

Copy link
Contributor Author

@LamentXU123 LamentXU123 Jun 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will work on this recently for a feature request. Good idea tho. I'm pretty interested. I will launch another issue with PR when I'm done.

Copy link
Contributor Author

@LamentXU123 LamentXU123 Jun 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I think we could just use this before the FR, since its been there for a while. And I'm not sure changing it to global var(or class var) and add customizing won't cause some strange bugs elsewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the updated list of second-domain will likely become the default one in customization. For now I think we could just update it as a hard code and change it after the FR is done

"co", "ac", "com", "edu", "org", "net",
"gov", "mil", "int", "aero", "biz", "cat", "coop",
"info", "jobs", "mobi", "museum", "name", "pro",
"travel", "eu", "tv", "or", "nom", "sch", "web",
)
if sld.lower() in known_slds and len(tld) == 2:
# domain like .co.uk
_debug(" country-code second level domain %s", domain)
return False
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-06-15-03-38-13.gh-issue-135528.XssMeM.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:mod:`http.cookiejar`: add "tv", "or", "nom", "sch", and "web"
to the list of supported country code second-level domains.
Loading