gh-134538: link to example for windows readonly file handling in function docs #135540
Conversation
bedevere-app
bot
added
awaiting review
docs
ZeroIntensity
added
needs backport to 3.13
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Thanks!
@zooba or @chris-eibl: As Windows experts, would either of you like to look at this one?
chris-eibl
left a comment
chris-eibl
left a comment
There was a problem hiding this comment.
LGTM. A link to an example is always a good thing.
|
It's not particularly a Windows-specific example, so it seems like mentioning that might put people off reading it. It's a good example of using the error callback. Also I think we tend to use just "See ..." for examples, rather than "See Also" callouts. But that's a question for the docs WG. |
alex-semenyuk
force-pushed
the
link_to_shutil-rmtree-example
branch
from
96a60bb to
1bd0a48
Compare
|
Agree. Removed Windows mention |
|
Thanks @alex-semenyuk for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…ythonGH-135540) (cherry picked from commit e9b647d) Co-authored-by: alexey semenyuk <[email protected]>
|
GH-135691 is a backport of this pull request to the 3.14 branch. |
…ythonGH-135540) (cherry picked from commit e9b647d) Co-authored-by: alexey semenyuk <[email protected]>
|
GH-135692 is a backport of this pull request to the 3.13 branch. |
) (cherry picked from commit e9b647d) Co-authored-by: alexey semenyuk <[email protected]>
) (cherry picked from commit e9b647d) Co-authored-by: alexey semenyuk <[email protected]>
4 participants
Link to example for windows readonly file handling in function docs
📚 Documentation preview 📚: https://cpython-previews--135540.org.readthedocs.build/en/135540/library/shutil.html#shutil.rmtree