- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.3k
 
gh-127146: Allow ignored keys to be missing in test_sysconfig #135622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            freakboy3742
  merged 1 commit into
  python:main
from
hoodmane:emscripten-test-sysconfig-fix
  
      
      
   
  Jun 18, 2025 
      
    
                
     Merged
            
            gh-127146: Allow ignored keys to be missing in test_sysconfig #135622
                    freakboy3742
  merged 1 commit into
  python:main
from
hoodmane:emscripten-test-sysconfig-fix
  
      
      
   
  Jun 18, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Fixes the test on Emscripten where userbase can be missing.
              
                    freakboy3742
  
              
              approved these changes
              
                  
                    Jun 18, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| 
           Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.  | 
    
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Jun 18, 2025 
    
    
      
  
    
      
    
  
…ythonGH-135622) Fixes the test on Emscripten where userbase can be missing. (cherry picked from commit 28c71ee) Co-authored-by: Hood Chatham <[email protected]>
| 
           GH-135650 is a backport of this pull request to the 3.14 branch.  | 
    
    
  freakboy3742 
      pushed a commit
      that referenced
      this pull request
    
      Jun 18, 2025 
    
    
      
  
    
      
    
  
…H-135622) (#135650) Fixes the test on Emscripten where userbase can be missing. (cherry picked from commit 28c71ee) Co-authored-by: Hood Chatham <[email protected]>
    
  lkollar 
      pushed a commit
        to lkollar/cpython
      that referenced
      this pull request
    
      Jun 19, 2025 
    
    
      
  
    
      
    
  
…ython#135622) Fixes the test on Emscripten where userbase can be missing.
    
  Pranjal095 
      pushed a commit
        to Pranjal095/cpython
      that referenced
      this pull request
    
      Jul 12, 2025 
    
    
      
  
    
      
    
  
…ython#135622) Fixes the test on Emscripten where userbase can be missing.
    
  taegyunkim 
      pushed a commit
        to taegyunkim/cpython
      that referenced
      this pull request
    
      Aug 4, 2025 
    
    
      
  
    
      
    
  
…ython#135622) Fixes the test on Emscripten where userbase can be missing.
    
  Agent-Hellboy 
      pushed a commit
        to Agent-Hellboy/cpython
      that referenced
      this pull request
    
      Aug 19, 2025 
    
    
      
  
    
      
    
  
…ython#135622) Fixes the test on Emscripten where userbase can be missing.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes the test on Emscripten where userbase can be missing.