GH-132532: Make CHECK_PERIODIC an instruction, not just a uop. #135772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reimplementation of #132533 (which I forgot about, sorry @iritkatriel) but with support for
CALL_KW,CALL_FUNCTION_EXand a tier2 version that doesn't escape.Initial benchmarking was about 0.5% slower across the platforms.
Stats showed that
CHECK_PERIODICwas 7.1% of all instructions.To mitigate this, this PR also:
CHECK_PERIODIChas been emitted in a basic block, and not emit it twice without an intervening call.CHECK_PERIODICinCALL_PY_EXACT_ARGSandCALL_PY_GENERALas they will have checked the eval breaker.CALL_LIST_APPENDto check the eval breaker or this loop might never check the eval breaker:📚 Documentation preview 📚: https://cpython-previews--135772.org.readthedocs.build/