Skip to content

gh-135532: fortify DEBUG checks when fetching HACL*-based module state #135844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

gh-135532: fortify DEBUG checks when fetching HACL*-based module state #135844

wants to merge 4 commits into from
+212 −123

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Jun 23, 2025 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested review from gpshead and tiran as code owners June 23, 2025 10:48
@picnixz picnixz added the type-refactor Code refactoring (with no changes in behavior) label Jun 23, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 23, 2025
Closed
@picnixz

This comment was marked as resolved.

Sign in to view
@bedevere-bot

This comment was marked as resolved.

Sign in to view
@picnixz

This comment was marked as resolved.

Sign in to view
@bedevere-bot

This comment was marked as resolved.

Sign in to view
@picnixz
Copy link
Member Author

picnixz commented Jun 27, 2025

I'm tempted to merge this one, but at the same time, I'm tempted to have a more generic helper for such checks so that we can add it to every module that assumes _PyType_GetModuleState is safe.

@picnixz picnixz marked this pull request as draft July 11, 2025 16:21
@picnixz
Copy link
Member Author

picnixz commented Jul 13, 2025

I won't use this one so I'll just close it.

@picnixz picnixz closed this Jul 13, 2025
@picnixz picnixz deleted the refactor/hashlib/module-methods-135532 branch July 13, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

skip news type-refactor Code refactoring (with no changes in behavior)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @bedevere-bot