Skip to content

[3.14] gh-135878: Fix crash in types.SimpleNamespace.__repr__ (GH-135889) #135896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

[3.14] gh-135878: Fix crash in types.SimpleNamespace.__repr__ (GH-135889) #135896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2025-06-24-14-43-24.gh-issue-135878.Db4roX.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fixes a crash of :class:`types.SimpleNamespace` on :term:`free threading` builds,
when several threads were calling its :meth:`~object.__repr__` method at the
same time.
7 changes: 4 additions & 3 deletions Objects/namespaceobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,10 @@ namespace_repr(PyObject *ns)
if (PyUnicode_Check(key) && PyUnicode_GET_LENGTH(key) > 0) {
PyObject *value, *item;

value = PyDict_GetItemWithError(d, key);
if (value != NULL) {
int has_key = PyDict_GetItemRef(d, key, &value);
if (has_key == 1) {
item = PyUnicode_FromFormat("%U=%R", key, value);
Py_DECREF(value);
if (item == NULL) {
loop_error = 1;
}
Expand All @@ -135,7 +136,7 @@ namespace_repr(PyObject *ns)
Py_DECREF(item);
}
}
else if (PyErr_Occurred()) {
else if (has_key < 0) {
loop_error = 1;
}
}
Expand Down
Loading