Skip to content

Conversation

@duaneg
Copy link
Contributor

@duaneg duaneg commented Jun 25, 2025

Attempt to clarify in the documentation that care must be taken when using multiprocessing classes to implement logging since they have builtin internal logging, and hence may cause deadlock/infinite recursion.


📚 Documentation preview 📚: https://cpython-previews--135954.org.readthedocs.build/

…inite recursion

Attempt to clarify in the documentation that care must be taken when using
multiprocessing classes to implement logging since they have builtin internal
logging, and hence may cause deadlock/infinite recursion.
@bedevere-app
Copy link

bedevere-app bot commented Jun 26, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vsajip vsajip merged commit a4625d5 into python:main Jun 26, 2025
28 of 29 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jun 26, 2025
@vsajip vsajip added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 26, 2025
@miss-islington-app
Copy link

Thanks @duaneg for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @duaneg for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
…inite recursion (pythonGH-135954)

* pythongh-91555: add warning to docs about possibility of deadlock/infinite recursion

Attempt to clarify in the documentation that care must be taken when using
multiprocessing classes to implement logging since they have builtin internal
logging, and hence may cause deadlock/infinite recursion.

* Update Doc/library/logging.handlers.rst

Co-authored-by: Vinay Sajip <[email protected]>

* Change whitespace.

---------
(cherry picked from commit a4625d5)

Co-authored-by: Duane Griffin <[email protected]>
Co-authored-by: Vinay Sajip <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
…inite recursion (pythonGH-135954)

* pythongh-91555: add warning to docs about possibility of deadlock/infinite recursion

Attempt to clarify in the documentation that care must be taken when using
multiprocessing classes to implement logging since they have builtin internal
logging, and hence may cause deadlock/infinite recursion.

* Update Doc/library/logging.handlers.rst

Co-authored-by: Vinay Sajip <[email protected]>

* Change whitespace.

---------
(cherry picked from commit a4625d5)

Co-authored-by: Duane Griffin <[email protected]>
Co-authored-by: Vinay Sajip <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 26, 2025

GH-135988 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 26, 2025

GH-135989 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 26, 2025
vsajip pushed a commit that referenced this pull request Jun 26, 2025
vsajip pushed a commit that referenced this pull request Jun 26, 2025
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
…inite recursion (pythonGH-135954)

* pythongh-91555: add warning to docs about possibility of deadlock/infinite recursion

Attempt to clarify in the documentation that care must be taken when using
multiprocessing classes to implement logging since they have builtin internal
logging, and hence may cause deadlock/infinite recursion.

* Update Doc/library/logging.handlers.rst

Co-authored-by: Vinay Sajip <[email protected]>

* Change whitespace.

---------

Co-authored-by: Vinay Sajip <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…inite recursion (pythonGH-135954)

* pythongh-91555: add warning to docs about possibility of deadlock/infinite recursion

Attempt to clarify in the documentation that care must be taken when using
multiprocessing classes to implement logging since they have builtin internal
logging, and hence may cause deadlock/infinite recursion.

* Update Doc/library/logging.handlers.rst

Co-authored-by: Vinay Sajip <[email protected]>

* Change whitespace.

---------

Co-authored-by: Vinay Sajip <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…inite recursion (pythonGH-135954)

* pythongh-91555: add warning to docs about possibility of deadlock/infinite recursion

Attempt to clarify in the documentation that care must be taken when using
multiprocessing classes to implement logging since they have builtin internal
logging, and hence may cause deadlock/infinite recursion.

* Update Doc/library/logging.handlers.rst

Co-authored-by: Vinay Sajip <[email protected]>

* Change whitespace.

---------

Co-authored-by: Vinay Sajip <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
…inite recursion (pythonGH-135954)

* pythongh-91555: add warning to docs about possibility of deadlock/infinite recursion

Attempt to clarify in the documentation that care must be taken when using
multiprocessing classes to implement logging since they have builtin internal
logging, and hence may cause deadlock/infinite recursion.

* Update Doc/library/logging.handlers.rst

Co-authored-by: Vinay Sajip <[email protected]>

* Change whitespace.

---------

Co-authored-by: Vinay Sajip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants