gh-78465: Fix error message for cls.__new__(cls, ...) where cls is not instantiable #135981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not instantiable Previous error message suggested to use cls.__new__(), which obviously does not work. Now the error message is the same as for cls(...).
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 27, 2025
… is not instantiable (pythonGH-135981) Previous error message suggested to use cls.__new__(), which obviously does not work. Now the error message is the same as for cls(...). (cherry picked from commit c45f4f3) Co-authored-by: Serhiy Storchaka <[email protected]>
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-136030 is a backport of this pull request to the 3.14 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 27, 2025
…ere cls is not instantiable (pythonGH-135981) Previous error message suggested to use cls.__new__(), which obviously does not work. Now the error message is the same as for cls(...). (cherry picked from commit c45f4f3) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-136031 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jun 27, 2025
…ere cls is not instantiable (pythonGH-135981) Previous error message suggested to use cls.__new__(), which obviously does not work. Now the error message is the same as for cls(...). (cherry picked from commit c45f4f3) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 27, 2025
…s is not instantiable (GH-135981) (GH-136030) Previous error message suggested to use cls.__new__(), which obviously does not work. Now the error message is the same as for cls(...). (cherry picked from commit c45f4f3) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 27, 2025
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
… is not instantiable (pythonGH-135981) Previous error message suggested to use cls.__new__(), which obviously does not work. Now the error message is the same as for cls(...).
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
… is not instantiable (pythonGH-135981) Previous error message suggested to use cls.__new__(), which obviously does not work. Now the error message is the same as for cls(...).
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
… is not instantiable (pythonGH-135981) Previous error message suggested to use cls.__new__(), which obviously does not work. Now the error message is the same as for cls(...).
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
… is not instantiable (pythonGH-135981) Previous error message suggested to use cls.__new__(), which obviously does not work. Now the error message is the same as for cls(...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous error message suggested to use cls.new(), which obviously does not work. Now the error message is the same as for cls(...).
__new__on non-instaniable objects #78465