gh-136063: fix quadratic-complexity parsing in email.message._parseparam
#136072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
force-pushed
the
fix/email/parseparam-dos-136063
branch
from
8763366 to
d356a14
Compare
aeurielesn
reviewed
Jul 19, 2025
picnixz
added
needs backport to 3.9
needs backport to 3.10
Member
Author
|
@serhiy-storchaka friendly ping |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…parseparam` (pythonGH-136072) (cherry picked from commit 680a5d0) Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…parseparam` (pythonGH-136072) (cherry picked from commit 680a5d0) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-140827 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…parseparam` (pythonGH-136072) (cherry picked from commit 680a5d0) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-140828 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…parseparam` (pythonGH-136072) (cherry picked from commit 680a5d0) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-140829 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…parseparam` (pythonGH-136072) (cherry picked from commit 680a5d0) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-140830 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2025
…parseparam` (pythonGH-136072) (cherry picked from commit 680a5d0) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-140831 is a backport of this pull request to the 3.10 branch. |
|
GH-140832 is a backport of this pull request to the 3.9 branch. |
ambv
pushed a commit
that referenced
this pull request
Oct 31, 2025
…parseparam` (GH-136072) (GH-140832) (cherry picked from commit 680a5d0) Co-authored-by: Bénédikt Tran <[email protected]>
ambv
added a commit
that referenced
this pull request
Oct 31, 2025
…_parseparam` (GH-136072) (GH-140830) (cherry picked from commit 680a5d0) Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Nov 30, 2025
…_parseparam` (GH-136072) (#140827) Co-authored-by: Bénédikt Tran <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Nov 30, 2025
…_parseparam` (GH-136072) (#140828) Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@serhiy-storchaka I think this one can be done without changing the interface. Just to be sure, but
count()andfind()have all linear complexities right (linear in the window they are using, not in the entire string).emailModule #136063