-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-127604: Docs: Include a C stack in the faulthandler example
#136081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127604: Docs: Include a C stack in the faulthandler example
#136081
Conversation
faulthandler examplefaulthandler example
|
@picnixz Are you around to do a quick review? |
|
I'm around for 3h max and then I'm off for 10 days. |
picnixz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's omit some lines even if it won't be omitted. If we change how string_at behaves or if the way calls are performed change, then it will need us to rewrite this example. Instead, I suggest to have some ... after _Py_DumpStack
|
I think it's ok to keep the addresses there for completeness, it's there as an example, not necessarily as a precise depiction of what happens if you call |
|
May I suggest replacing |
picnixz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you about the different line numbers (hopefully it's coming from a real example).
|
Yeah, I just copy-pasted the output from a local run of |
|
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
pythonGH-136081) (cherry picked from commit 3947847) Co-authored-by: Peter Bierma <[email protected]>
|
GH-136102 is a backport of this pull request to the 3.14 branch. |
This is to showcase the new feature in 3.14.
faulthandler#127604📚 Documentation preview 📚: https://cpython-previews--136081.org.readthedocs.build/en/136081/library/faulthandler.html#example