Skip to content

[3.14] gh-135607: remove null checking of weakref list in dealloc of extension modules and objects (#135614) #136119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

[3.14] gh-135607: remove null checking of weakref list in dealloc of extension modules and objects (#135614) #136119

merged 1 commit into from
Jun 30, 2025

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 30, 2025 •
edited by bedevere-app bot
Loading

@xuantengh @kumaraditya303 @vstinner
pythongh-135607: remove null checking of weakref list in dealloc of e…
79bd8ba 
…xtension modules and objects (python#135614)

Co-authored-by: Kumar Aditya <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit b1056c2)
@bedevere-app bedevere-app bot mentioned this pull request Jun 30, 2025
Merged
@bedevere-app bedevere-app bot mentioned this pull request Jun 30, 2025
Closed
@vstinner
Copy link
Member Author

I fixed a minor merge conflict in #include in Modules/_io/bytesio.c.

@vstinner vstinner merged commit 3267847 into python:3.14 Jun 30, 2025
49 checks passed
@vstinner vstinner deleted the weakref_null14 branch June 30, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @kumaraditya303 @xuantengh