gh-135075: Make PyObject_SetAttr() fail with NULL value and exception #136180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Generally looks good to me.
blockchainGuru1018
approved these changes
Jul 1, 2025
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I think that Modules/_testcapi/abstract.c is better place than Modules/_testcapi/object.c.
Member
Author
I moved the C code. |
encukou
approved these changes
Jul 2, 2025
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, although I think that the documentation could be improved.
Member
Author
|
Merged, thanks for reviews.
I'm not good at writing documentation. Since the PR got multiple approvals, I merged my PR. |
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
…eption (python#136180) Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…eption (python#136180) Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
…eption (python#136180) Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…eption (python#136180) Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…eption (python#136180) Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.
📚 Documentation preview 📚: https://cpython-previews--136180.org.readthedocs.build/