- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.3k
 
          gh-136193: Improve TypeError msg when comparing two SimpleNamespaces
          #136195
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    picnixz
  
              
              reviewed
              
                  
                    Jul 2, 2025 
                  
              
              
            
            
              
                    efimov-mikhail
  
              
              approved these changes
              
                  
                    Jul 2, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm on renaming test to test_richcompare_unsupported.
Co-authored-by: Bénédikt Tran <[email protected]>
              
                    picnixz
  
              
              approved these changes
              
                  
                    Jul 2, 2025 
                  
              
              
            
            
| 
           We usually don't backport error message changes, so I won't backport this as well.  | 
    
| 
           yes i waiting from this  | 
    
    
  AndPuQing 
      pushed a commit
        to AndPuQing/cpython
      that referenced
      this pull request
    
      Jul 11, 2025 
    
    
      
  
    
      
    
  
…mespace`s (python#136195) Co-authored-by: Bénédikt Tran <[email protected]>
    
  Pranjal095 
      pushed a commit
        to Pranjal095/cpython
      that referenced
      this pull request
    
      Jul 12, 2025 
    
    
      
  
    
      
    
  
…mespace`s (python#136195) Co-authored-by: Bénédikt Tran <[email protected]>
    
  picnixz 
      added a commit
        to picnixz/cpython
      that referenced
      this pull request
    
      Jul 13, 2025 
    
    
      
  
    
      
    
  
…mespace`s (python#136195) Co-authored-by: Bénédikt Tran <[email protected]>
    
  taegyunkim 
      pushed a commit
        to taegyunkim/cpython
      that referenced
      this pull request
    
      Aug 4, 2025 
    
    
      
  
    
      
    
  
…mespace`s (python#136195) Co-authored-by: Bénédikt Tran <[email protected]>
    
  Agent-Hellboy 
      pushed a commit
        to Agent-Hellboy/cpython
      that referenced
      this pull request
    
      Aug 19, 2025 
    
    
      
  
    
      
    
  
…mespace`s (python#136195) Co-authored-by: Bénédikt Tran <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
types.SimpleNamespaceobjects #136193