gh-125862: Context decorator support for generators and async functions #136212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ack. WASI tests are failing because I used asyncio. Gotta work around that. |
Zac-HD
reviewed
Jul 28, 2025
Comment on lines
+90
to
+91
| with self._recreate_cm(): | ||
| yield from func(*args, **kwds) |
There was a problem hiding this comment.
Suggested change
| with self._recreate_cm(): | |
| yield from func(*args, **kwds) | |
| with self._recreate_cm(), closing(func(*args, **kwds)) as gen: | |
| yield from gen |
I think we should be using with closing() and async with aclosing() in these wrappers, to ensure that any resources held by the wrapped function are cleaned up promptly. (see e.g. PEP-533 motivation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contextlib.ContextDecoratorsupport for generators and async functions #125862