Skip to content

gh-136228: Clarify example in exception handling section #136257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-136228: Clarify example in exception handling section #136257

wants to merge 1 commit into from

Conversation

@KentaroJay
Copy link
Contributor

@KentaroJay KentaroJay commented Jul 3, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 3, 2025
Open
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jul 3, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jul 3, 2025
@KentaroJay KentaroJay marked this pull request as ready for review July 3, 2025 20:54
@KentaroJay
Copy link
Contributor Author

Hi @Krisselack, is it possible to get a review from you? (You created the issue, you know best about this PR :D)

@Krisselack
Copy link

Hi @Krisselack, is it possible to get a review from you? (You created the issue, you know best about this PR :D)
Dear @KentaroJay:
looks much clearer now to me, thank you! Should I do something more formally (as approval)?

@KentaroJay
Copy link
Contributor Author

Dear @KentaroJay:

looks much clearer now to me, thank you! Should I do something more formally (as approval)?

Yeah if it looks good to you, I appreciate it if you hit approve. Thanks!!

Krisselack
Krisselack approved these changes Jul 30, 2025
View reviewed changes
Copy link

@Krisselack Krisselack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example is much clearer now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Krisselack Krisselack Krisselack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KentaroJay @Krisselack