gh-136288: Correct error display in _testcapi/vectorcall.c #136258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ZeroIntensity
added
tests
Use %N instead of %S and PyType_GetName.
ZeroIntensity
changed the title
ZeroIntensity
approved these changes
Jul 4, 2025
There was a problem hiding this comment.
LGTM, thanks. I've created gh-136288 and attached it to the PR for you.
|
Thanks @wsfulton for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 4, 2025
…nGH-136258) Use the %N format specifier instead of %s and `PyType_GetName`. (cherry picked from commit d1d5dce) Co-authored-by: William S Fulton <[email protected]>
|
GH-136294 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 4, 2025
…nGH-136258) Use the %N format specifier instead of %s and `PyType_GetName`. (cherry picked from commit d1d5dce) Co-authored-by: William S Fulton <[email protected]>
|
GH-136295 is a backport of this pull request to the 3.13 branch. |
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
…nGH-136258) Use the %N format specifier instead of %s and `PyType_GetName`.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…nGH-136258) Use the %N format specifier instead of %s and `PyType_GetName`.
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
…nGH-136258) Use the %N format specifier instead of %s and `PyType_GetName`.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…nGH-136258) Use the %N format specifier instead of %s and `PyType_GetName`.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…nGH-136258) Use the %N format specifier instead of %s and `PyType_GetName`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct incorrect conversion specifier in test from %s to %S for
PyObject *. I could have added a test, but that would be testing the test!_testcapihas invalid usage ofPyType_GetName#136288