Skip to content

Replace weakref to the _WeakValueDictionary with strong ref to outlives keys #136345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Replace weakref to the _WeakValueDictionary with strong ref to outlives keys #136345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/importlib/_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class _List(list):
class _WeakValueDictionary:

def __init__(self):
self_weakref = _weakref.ref(self)
# self_weakref = _weakref.ref(self)

# Inlined to avoid issues with inheriting from _weakref.ref before _weakref is
# set by _setup(). Since there's only one instance of this class, this is
Expand All @@ -81,9 +81,9 @@ def __init__(self, ob, key):

@staticmethod
def remove(wr):
nonlocal self_weakref
nonlocal self

self = self_weakref()
# self = self_weakref()
if self is not None:
if self._iterating:
self._pending_removals.append(wr.key)
Expand Down
Loading