gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and ** #136395
Conversation
|
All commit authors signed the Contributor License Agreement. |
Tapeline
changed the title
| funcstr, Py_TYPE(args)->tp_name); | ||
| Py_DECREF(funcstr); | ||
| } | ||
| _PyErr_Format(tstate, PyExc_TypeError, |
There was a problem hiding this comment.
Why not to use %T formatter here? IIUC it is preferable now.
There was a problem hiding this comment.
Nikita's suggestions on removing the function name entirely were motivated by the fact that getting this name is not fast and does not add much value (in fact, none at all). I've looked into the %T specification, and it seems to do x2 of work we just got rid of, so I doubt that that would be a positive change. Anyway, we're waiting on Mark's review on that, maybe he has another opinion
|
@markshannon, could you please review this? |
Misc/NEWS.d/next/Core_and_Builtins/2025-07-08-00-41-46.gh-issue-136327.7AiTb_.rst
Outdated
Show resolved
Hide resolved
|
Hi, @hugovk, could you please take a look at the error message wording change, since you are an RM. Do you think it looks better now? :) |
5 participants
Solved removing function name from error message entirely