gh-136516: Mention installation artifacts as de-facto resources #136419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files like NUL on windows are, from `importlib.resources` point of view, an artifact caused by installing to a filesystem directory. Mention these.
encukou
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
bedevere-app
bot
added
awaiting core review
docs
pfmoore
approved these changes
Jul 9, 2025
encukou
changed the title
encukou
added
needs backport to 3.13
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 23, 2025
…pythonGH-136419) Files like NUL on windows are, from `importlib.resources` point of view, an artifact caused by installing to a filesystem directory. Mention these. (cherry picked from commit fac4964) Co-authored-by: Petr Viktorin <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 23, 2025
…pythonGH-136419) Files like NUL on windows are, from `importlib.resources` point of view, an artifact caused by installing to a filesystem directory. Mention these. (cherry picked from commit fac4964) Co-authored-by: Petr Viktorin <[email protected]>
|
GH-137038 is a backport of this pull request to the 3.14 branch. |
|
GH-137039 is a backport of this pull request to the 3.13 branch. |
encukou
added a commit
that referenced
this pull request
Jul 24, 2025
GH-136419) (GH-137039) Files like NUL on windows are, from `importlib.resources` point of view, an artifact caused by installing to a filesystem directory. Mention these. (cherry picked from commit fac4964) Co-authored-by: Petr Viktorin <[email protected]>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…pythonGH-136419) Files like NUL on windows are, from `importlib.resources` point of view, an artifact caused by installing to a filesystem directory. Mention these.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…pythonGH-136419) Files like NUL on windows are, from `importlib.resources` point of view, an artifact caused by installing to a filesystem directory. Mention these.
kumaraditya303
pushed a commit
that referenced
this pull request
Oct 7, 2025
GH-136419) (#137038) gh-136516: Mention installation artifacts as de-facto resources (GH-136419) Files like NUL on windows are, from `importlib.resources` point of view, an artifact caused by installing to a filesystem directory. Mention these. (cherry picked from commit fac4964) Co-authored-by: Petr Viktorin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files like NUL on windows are, from
importlib.resourcespoint of view, an artifact caused by installing to a filesystem directory.@jaraco, do you agree? Do you think it's worth mentioning?
📚 Documentation preview 📚: https://cpython-previews--136419.org.readthedocs.build/