Skip to content

gh-136394: Fix race condition in test_zstd #136432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

gh-136394: Fix race condition in test_zstd #136432

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a1bd7
Fix race condition in test_zstd
Rogdham Jul 8, 2025
cc34f8e
Reword comment based on Emma suggestion
Rogdham Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Lib/test/test_zstd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2673,8 +2673,12 @@ def test_compress_locking(self):
input = b'a'* (16*_1K)
num_threads = 8

# gh-136394: the first output of comp.compress includes the frame header
# so it is different than the others
# this is why it is added outside of the threading part

comp = ZstdCompressor()
parts = []
parts = [comp.compress(input, ZstdCompressor.FLUSH_BLOCK)]
for _ in range(num_threads):
res = comp.compress(input, ZstdCompressor.FLUSH_BLOCK)
if res:
Expand All @@ -2683,7 +2687,7 @@ def test_compress_locking(self):
expected = b''.join(parts) + rest1

comp = ZstdCompressor()
output = []
output = [comp.compress(input, ZstdCompressor.FLUSH_BLOCK)]
def run_method(method, input_data, output_data):
res = method(input_data, ZstdCompressor.FLUSH_BLOCK)
if res:
Expand Down
Loading