gh-52876: Implement missing parameter in codecs.StreamReaderWriter functions
#136498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
added
needs backport to 3.13
|
I'm not sure about the backports, though. This could be seen as a new feature. |
|
Thanks @StanFromIreland for the PR, and @malemburg for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 10, 2025
…iter` functions (pythonGH-136498) Closes pythonGH-52876 (cherry picked from commit 35e2c35) Co-authored-by: Stan Ulbrych <[email protected]>
|
It currently contradicts the docs, and this would bring it to the expected behaviour. There was a similar consensus on the issue. |
|
GH-136514 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 10, 2025
…iter` functions (pythonGH-136498) Closes pythonGH-52876 (cherry picked from commit 35e2c35) Co-authored-by: Stan Ulbrych <[email protected]>
|
GH-136515 is a backport of this pull request to the 3.13 branch. |
Fair enough. |
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
…iter` functions (python#136498) Closes python#52876
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…iter` functions (python#136498) Closes python#52876
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
…iter` functions (python#136498) Closes python#52876
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…iter` functions (python#136498) Closes python#52876
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…iter` functions (python#136498) Closes python#52876
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…eaderWriter` functions (pythonGH-136498) (python#136514) pythongh-52876: Implement missing parameter in `codecs.StreamReaderWriter` functions (pythonGH-136498) Closes pythonGH-52876 (cherry picked from commit 35e2c35) Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug since, per docs: