Skip to content

gh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE mode was set #136518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 10, 2025
Merged

gh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE mode was set #136518

merged 5 commits into from
Jul 10, 2025

Conversation

@sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Jul 10, 2025 •
edited
Loading

There was a typo, and uncollectable objects printed only if DEBUG_COLLECTABLE mode is set.
Affected main and 3.14 (183b020)

cpython/Python/gc.c

Lines 1783 to 1787 in 59acdba

for (gc = GC_NEXT(&finalizers); gc != &finalizers; gc = GC_NEXT(gc)) {
n++;
if (gcstate->debug & _PyGC_DEBUG_COLLECTABLE)
debug_cycle("uncollectable", FROM_GC(gc));
}

@bedevere-app bedevere-app bot mentioned this pull request Jul 10, 2025
Closed
@Eclips4 Eclips4 added the needs backport to 3.14 bugs and security fixes label Jul 10, 2025
@sergey-miryanov
Copy link
Contributor Author

@pablogsal @nascheme It is ready to review. Please take a look!

pablogsal
pablogsal approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good catch!

@pablogsal pablogsal merged commit c560df9 into python:main Jul 10, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @sergey-miryanov for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2025
@sergey-miryanov @miss-islington
pythongh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE m…
7a29a47 
…ode was set (pythonGH-136518)

(cherry picked from commit c560df9)

Co-authored-by: Sergey Miryanov <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 10, 2025

GH-136522 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 10, 2025
@sergey-miryanov
Copy link
Contributor Author

Thanks everyone!

@sergey-miryanov sergey-miryanov deleted the gc-print-uncollectable branch July 11, 2025 04:58
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@sergey-miryanov @AndPuQing
pythongh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE m…
4af89d2 
…ode was set (python#136518)
pablogsal pushed a commit that referenced this pull request Jul 11, 2025
@miss-islington @sergey-miryanov
[3.14] gh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE …
e03db73 
…mode was set (GH-136518) (#136522)

gh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE mode was set (GH-136518)
(cherry picked from commit c560df9)

Co-authored-by: Sergey Miryanov <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sergey-miryanov @Pranjal095
pythongh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE m…
af5dcf5 
…ode was set (python#136518)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@sergey-miryanov @picnixz
pythongh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE m…
9a22ea2 
…ode was set (python#136518)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@sergey-miryanov @taegyunkim
pythongh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE m…
19f6a06 
…ode was set (python#136518)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@sergey-miryanov @Agent-Hellboy
pythongh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE m…
92d73b0 
…ode was set (python#136518)
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @sergey-miryanov @kumaraditya303
[3.14] pythongh-136517: Print uncollectable objects if DEBUG_UNCOLLEC…
9796f1d 
…TABLE mode was set (pythonGH-136518) (python#136522)

pythongh-136517: Print uncollectable objects if DEBUG_UNCOLLECTABLE mode was set (pythonGH-136518)
(cherry picked from commit c560df9)

Co-authored-by: Sergey Miryanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sergey-miryanov @pablogsal @Eclips4