Skip to content

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 11, 2025

@ZeroIntensity
Copy link
Member

Is there any reason this wasn't caught by regrtest?

@serhiy-storchaka
Copy link
Member Author

Regrtest sets different threading.excepthook.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. The core change looks good to me. Could we add a simple test for this? Something like inspect.signature(threading.__excepthook__) should work.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit be2c3d2 into python:main Jul 12, 2025
45 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 12, 2025

GH-136589 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 12, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 12, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 12, 2025

GH-136590 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 12, 2025
@serhiy-storchaka serhiy-storchaka deleted the threading-excepthook-signature branch July 12, 2025 15:54
serhiy-storchaka added a commit that referenced this pull request Jul 12, 2025
serhiy-storchaka added a commit that referenced this pull request Jul 12, 2025
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants