Skip to content

Conversation

@duaneg
Copy link
Contributor

@duaneg duaneg commented Jul 15, 2025

Add an option to manually exclude ncurses from the build.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't forget to update Doc/using/configure.rst with the new option.

I haven't reviewed the AC code, because I am not an expert there :)

…pping

building the python curses module as opposed to not using the system ncurses
library.

Remove mistakenly repeated test modules section.

Document configure option.
@duaneg
Copy link
Contributor Author

duaneg commented Jul 20, 2025

Please, don't forget to update Doc/using/configure.rst with the new option.

Ah, thanks! I didn't spot those docs, updated. On review I think it would be better to think of this from the higher-level user perspective of excluding the curses module, rather than the lower-level build perspective of "skipping a system library check". I've renamed the option --disable-curses, instead of disable-ncurses, accordingly.

Although that does prompt the question of whether we should allow excluding other modules at build time. I'm not sure if this has been discussed before or would be considered useful.

I haven't reviewed the AC code, because I am not an expert there :)

As it turns out, I had made a silly mistake and left a copy & pasted chunk of code in there, so I'm glad you didn't review it as yet 🙂

A tip for reviewing: most of the configure.ac changes are making the libncurses checks conditional, and hence mostly just change indentation. If you review them ignoring whitespace the diff is much easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants