gh-136744: Remove unnecessary chmod from pydoc.apropos() test. #136746
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
added
tests
|
!buildbot emscripten |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 15b6a15 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136746%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks @freakboy3742 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 22, 2025
…ythonGH-136746) Remove unnecessary chmod from pydoc.apropos() test. (cherry picked from commit 04c4628) Co-authored-by: Russell Keith-Magee <[email protected]>
|
GH-139242 is a backport of this pull request to the 3.14 branch. |
zware
reviewed
Sep 22, 2025
| self.assertEqual(out.getvalue(), '') | ||
| self.assertEqual(err.getvalue(), '') | ||
|
|
||
| @os_helper.skip_unless_working_chmod |
There was a problem hiding this comment.
Looks like this decorator was missed; it shouldn't be necessary anymore.
There was a problem hiding this comment.
Good call - see #139267.
hugovk
pushed a commit
that referenced
this pull request
Sep 29, 2025
…GH-136746) (#139242) Co-authored-by: Russell Keith-Magee <[email protected]> Co-authored-by: Zachary Ware <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test added as part of fixing #65747 includes a chmod call that appears to be unrelated to the problem that was reported.
Part of the triage of that issue included the observation that the problem could be reproduced by removing execute permissions from a directory. However, this appears to be unrelated to the reported problem.
By removing the execute permission from the directory, the module is converted into a namespace package - at which point, it can't have a docstring. However, you can also validate empty docstring handling by... having a module without a docstring. Which is what the test implements.
Adding to the confusion - the test only removes user execute permissions. Group and Global execute permissions are retained. The original report removed all execute permissions, not just user execute permissions; so the test isn't reproducing the triage example. The only explanation I can think of for this is that the buildbots run with a umask of 0o77, which means removing user execute permissions is effectively equivalent to
chmod a-x... but it won't be for anyone who isn't running under buildbot.This PR removes the chmod call, which also allows for removing the workaround for Emscripten.
Thanks to @hoodmane for help diagnosing what was going on here.