Skip to content

gh-136787: raise consistent ValueError for bad hashes #136802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 20, 2025
Merged

gh-136787: raise consistent ValueError for bad hashes #136802

merged 6 commits into from
Jul 20, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jul 19, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 19, 2025
Closed
@picnixz
Copy link
Member Author

picnixz commented Jul 19, 2025

For now, I'm adding a skip news just to run the builbots. I'll come back tomorrow.

@picnixz
Copy link
Member Author

picnixz commented Jul 19, 2025

!buildbot FIPS only

@bedevere-bot

This comment was marked as resolved.

Sign in to view
@picnixz picnixz force-pushed the feat/hashlib/same-error-messages-136787 branch from d2fa695 to db6f4db Compare July 19, 2025 12:05
@picnixz
Copy link
Member Author

picnixz commented Jul 19, 2025

!buildbot FIPS only

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit db6f4db 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136802%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

@picnixz picnixz marked this pull request as ready for review July 19, 2025 17:45
@picnixz picnixz requested review from gpshead and tiran as code owners July 19, 2025 17:45
gpshead
gpshead reviewed Jul 19, 2025
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good, mostly little details in comments or naming

picnixz
picnixz commented Jul 19, 2025
View reviewed changes
picnixz
picnixz commented Jul 19, 2025
View reviewed changes
picnixz
picnixz commented Jul 19, 2025
View reviewed changes
picnixz
picnixz commented Jul 19, 2025
View reviewed changes
picnixz
picnixz commented Jul 19, 2025
View reviewed changes
picnixz
picnixz commented Jul 19, 2025
View reviewed changes
picnixz
picnixz commented Jul 19, 2025
View reviewed changes
@picnixz
Copy link
Member Author

picnixz commented Jul 19, 2025

I really should avoid using the web editor. I'll make the changes tomorrow.

@picnixz picnixz enabled auto-merge (squash) July 20, 2025 08:24
@picnixz picnixz disabled auto-merge July 20, 2025 08:25
@picnixz picnixz enabled auto-merge (squash) July 20, 2025 08:25
@picnixz picnixz merged commit 6be49ee into python:main Jul 20, 2025
41 checks passed
@picnixz picnixz deleted the feat/hashlib/same-error-messages-136787 branch July 20, 2025 08:52
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-136787: improve exception messages for invalid hash algorith…
9e3971e 
…ms (python#136802)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@picnixz @Agent-Hellboy
pythongh-136787: improve exception messages for invalid hash algorith…
ac38a74 
…ms (python#136802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead left review comments

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz @bedevere-bot @gpshead