Skip to content

gh-127598: Improve ModuleNotFoundError when -S is passed #136821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 20, 2025
Merged

gh-127598: Improve ModuleNotFoundError when -S is passed #136821

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
34c29cf
Improve ModuleNotFoundError when -S is passed
MonadChains Jul 19, 2025
05ad9ce
add blurb
MonadChains Jul 19, 2025
c31694a
improve code
MonadChains Jul 19, 2025
c14ce27
Test + feedbacks
MonadChains Jul 19, 2025
df7df73
feedbacks
MonadChains Jul 20, 2025
ca64ada
change library list
MonadChains Jul 20, 2025
2ba6351
fix test
MonadChains Jul 20, 2025
29aad1d
fix test
MonadChains Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,6 +1106,10 @@ def __init__(self, exc_type, exc_value, exc_traceback, *, limit=None,
suggestion = _compute_suggestion_error(exc_value, exc_traceback, wrong_name)
if suggestion:
self._str += f". Did you mean: '{suggestion}'?"
elif exc_type and issubclass(exc_type, ModuleNotFoundError) and \
sys.flags.no_site:
self._str += ". Site initialization is disabled, did you forget to add the \
site-package directory to sys.path?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traceback message has too many spaces in the middle:

ModuleNotFoundError: No module named 'foo'. Site initialization is disabled, did you forget to add the                 site-package directory to sys.path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fixed now, please test it again

elif exc_type and issubclass(exc_type, (NameError, AttributeError)) and \
getattr(exc_value, "name", None) is not None:
wrong_name = getattr(exc_value, "name", None)
Expand Down
Loading