Skip to content

gh-127598: Improve ModuleNotFoundError when -S is passed #136821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 20, 2025
Merged

gh-127598: Improve ModuleNotFoundError when -S is passed #136821

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
34c29cf
Improve ModuleNotFoundError when -S is passed
MonadChains Jul 19, 2025
05ad9ce
add blurb
MonadChains Jul 19, 2025
c31694a
improve code
MonadChains Jul 19, 2025
c14ce27
Test + feedbacks
MonadChains Jul 19, 2025
df7df73
feedbacks
MonadChains Jul 20, 2025
ca64ada
change library list
MonadChains Jul 20, 2025
2ba6351
fix test
MonadChains Jul 20, 2025
29aad1d
fix test
MonadChains Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,6 +1106,11 @@ def __init__(self, exc_type, exc_value, exc_traceback, *, limit=None,
suggestion = _compute_suggestion_error(exc_value, exc_traceback, wrong_name)
if suggestion:
self._str += f". Did you mean: '{suggestion}'?"
elif exc_type and issubclass(exc_type, ModuleNotFoundError) and \
sys.flags.no_site and \
getattr(exc_value, "name", None) not in sys.builtin_module_names:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature should use stdlib_module_names, not builtin module names.

Suggested change
getattr(exc_value, "name", None) not in sys.builtin_module_names:
getattr(exc_value, "name", None) not in sys.stdlib_module_names:

(It could be tested by importing a non-existent stdlib module, like msvcrt on *nix or grp on Windows. The note should not be added for those -- you can't solve a "wrong platform" issue by adding the site-packages directory.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented the feedback, and it case stdlib the message it's not thrown :)

self._str += (". Site initialization is disabled, did you forget to "
+ "add the site-package directory to sys.path?")
elif exc_type and issubclass(exc_type, (NameError, AttributeError)) and \
getattr(exc_value, "name", None) is not None:
wrong_name = getattr(exc_value, "name", None)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-07-19-17-08-09.gh-issue-127598.Mx8S-y.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improve ModuleNotFoundError by adding flavour text to exception when the
argument '-S' is passed. Contributed by Andrea Mattei
Loading