gh-73065: Add Date header if missing in smtplib send_message #136850
Conversation
|
All commit authors signed the Contributor License Agreement. |
Yoav11
changed the title
|
Please change the title to use the GitHub issue number. |
Yoav11
changed the title
| HOST, self.port, local_hostname='localhost', | ||
| timeout=support.LOOPBACK_TIMEOUT) | ||
| self.addCleanup(smtp.close) | ||
| self.assertEqual(smtp.send_message(msg), {}) |
There was a problem hiding this comment.
I am moving these assertions further up so that I can extract the date from the message in order to build the expected string
Misc/NEWS.d/next/Library/2025-07-20-09-51-25.bpo-28879.SLDgcy.rst
Outdated
Show resolved
Hide resolved
|
@Yoav11 A little suggestion, when you complete a suggestion, whether that be by implementing it or providing a reason why you are not going to, please mark the conversation as "Resolved," this keeps the PR more organized. |
|
Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide. |
|
@StanFromIreland the PR should be ready to be merged |
|
@StanFromIreland bump 🙂 |
|
The email experts have been requested, please be patient. |
|
Thanks for the update 🙂 |
6 participants
Description
this PR was created during EuroPython 2025 Sprint Weekend.
It builds on #5176 authored by @elafontaine
📚 Documentation preview 📚: https://cpython-previews--136850.org.readthedocs.build/