gh-136852: Emscripten: Add PYTHON_NODE_VERSION environment variable #136853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able To choose the node version we use. Together with: python/buildmaster-config#614 closes python#136852.
|
Does this need backporting to 3.14? |
|
Yes I think it would be good to backport this. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2025
…able (pythonGH-136853) To choose the node version we use. Together with: python/buildmaster-config#614 closes pythonGH-136852. (cherry picked from commit aec7f5f) Co-authored-by: Hood Chatham <[email protected]>
|
GH-136907 is a backport of this pull request to the 3.14 branch. |
|
Hmm well again it doesn't seem to work quite. |
hoodmane
added a commit
to hoodmane/cpython
that referenced
this pull request
Jul 21, 2025
We need to get rid of some whitespace to make this work.
ambv
pushed a commit
that referenced
this pull request
Jul 21, 2025
hoodmane
added a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2025
We need to get rid of some whitespace to make this work.
ambv
pushed a commit
that referenced
this pull request
Jul 21, 2025
…iable (GH-136853) (GH-136907) To choose the node version we use. Together with: python/buildmaster-config#614 closes GH-136852. (cherry picked from commit aec7f5f) Co-authored-by: Hood Chatham <[email protected]>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…able (python#136853) To choose the node version we use. Together with: python/buildmaster-config#614 closes python#136852.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
We need to get rid of some whitespace to make this work.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…able (python#136853) To choose the node version we use. Together with: python/buildmaster-config#614 closes python#136852.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
We need to get rid of some whitespace to make this work.
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…nt variable (pythonGH-136853) (pythonGH-136907) To choose the node version we use. Together with: python/buildmaster-config#614 closes pythonGH-136852. (cherry picked from commit aec7f5f) Co-authored-by: Hood Chatham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To choose the node version we use. Together with:
python/buildmaster-config#614 closes #136852.