Skip to content

gh-136854: Exit on error in make venv #136856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2025
Merged

gh-136854: Exit on error in make venv #136856

merged 1 commit into from
Jul 20, 2025

Conversation

nachocab
Copy link
Contributor

@nachocab nachocab commented Jul 20, 2025 •
edited by github-actions bot
Loading

@bedevere-app
Copy link

bedevere-app bot commented Jul 20, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jul 20, 2025
Closed
@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 20, 2025
hugovk
hugovk approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There's a similar Makefile in the PEPs repo, would you like to do the triple?

@hugovk hugovk enabled auto-merge (squash) July 20, 2025 12:07
@hugovk hugovk merged commit 9c2f91c into python:main Jul 20, 2025
41 checks passed
@miss-islington-app
Copy link

Thanks @nachocab for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2025
@nachocab @miss-islington
pythongh-136854: Exit on error in make venv (pythonGH-136856)
dad1dc5 
(cherry picked from commit 9c2f91c)

Co-authored-by: Nacho Caballero <[email protected]>
Co-authored-by: Nacho Caballero <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2025
@nachocab @miss-islington
pythongh-136854: Exit on error in make venv (pythonGH-136856)
68b645b 
(cherry picked from commit 9c2f91c)

Co-authored-by: Nacho Caballero <[email protected]>
Co-authored-by: Nacho Caballero <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 20, 2025

GH-136860 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 20, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 20, 2025

GH-136861 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 20, 2025
hugovk pushed a commit that referenced this pull request Jul 20, 2025
@miss-islington @nachocab
[3.14] gh-136854: Exit on error in make venv (GH-136856) (#136860)
ee37365 
Co-authored-by: Nacho Caballero <[email protected]>
Co-authored-by: Nacho Caballero <[email protected]>
hugovk pushed a commit that referenced this pull request Jul 20, 2025
@miss-islington @nachocab
[3.13] gh-136854: Exit on error in make venv (GH-136856) (#136861)
1172f4c 
Co-authored-by: Nacho Caballero <[email protected]>
Co-authored-by: Nacho Caballero <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 20, 2025
@nachocab @picnixz
pythongh-136854: Exit on error in make venv (python#136856)
33ac314 
Co-authored-by: Nacho Caballero <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@nachocab @taegyunkim
pythongh-136854: Exit on error in make venv (python#136856)
15f51e6 
Co-authored-by: Nacho Caballero <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@nachocab @Agent-Hellboy
pythongh-136854: Exit on error in make venv (python#136856)
4127177 
Co-authored-by: Nacho Caballero <[email protected]>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @nachocab @kumaraditya303
[3.14] pythongh-136854: Exit on error in make venv (pythonGH-136856) (
acb7541 
python#136860)

Co-authored-by: Nacho Caballero <[email protected]>
Co-authored-by: Nacho Caballero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

skip news sprint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent make venv from saying it succeeded when it failed

3 participants

@nachocab @hugovk @tomasr8