[3.14] gh-134411: assert PyLong_FromLong(x) != NULL when x is known to be small (GH-134415)
#136910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to be small (pythonGH-134415) Since `PyLong_From Long(PY_MONITORING_DEBUGGER_ID)` falls to `small_int` case and can't return `NULL`. Added `assert`s for extra confidence. python#134411 (comment) (cherry picked from commit cf19b64) Co-authored-by: Sergey Muraviov <[email protected]>
This was referenced Jul 21, 2025
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…is known to be small (pythonGH-134415) (python#136910) pythongh-134411: assert `PyLong_FromLong(x) != NULL` when `x` is known to be small (pythonGH-134415) Since `PyLong_From Long(PY_MONITORING_DEBUGGER_ID)` falls to `small_int` case and can't return `NULL`. Added `assert`s for extra confidence. python#134411 (comment) (cherry picked from commit cf19b64) Co-authored-by: Sergey Muraviov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
PyLong_From Long(PY_MONITORING_DEBUGGER_ID)falls tosmall_intcase and can't returnNULL. Addedasserts for extra confidence.#134411 (comment)
(cherry picked from commit cf19b64)
Co-authored-by: Sergey Muraviov [email protected]
Python/instrumentation.c: ensure non-NULLPyLong_FromLongresults when possible #134411