Skip to content

gh-136437: Make several functions in os.path pos-only #136949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 23, 2025
Merged

gh-136437: Make several functions in os.path pos-only #136949

merged 5 commits into from
Jul 23, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 21, 2025 •
edited by bedevere-app bot
Loading

Marking functions from #136812 and #136946 as accepting pos-only.

Not to be backported.

@bedevere-app bedevere-app bot mentioned this pull request Jul 21, 2025
Closed
serhiy-storchaka
serhiy-storchaka reviewed Jul 22, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not it update also samestat, samefile, maybe other functions in genericpath?

@sobolevn
Copy link
Member Author

Yes, I missed samestat and probably several others when created first PR. Because they have (s1, s2) which escaped my regex. We first need to document them as pos-only. Thanks for the good catch!

@sobolevn sobolevn marked this pull request as draft July 22, 2025 09:05
@sobolevn
Copy link
Member Author

I created #136970 to fix first

@AA-Turner
Copy link
Member

I created #136970 to fix first

Merged.

A

@sobolevn sobolevn marked this pull request as ready for review July 22, 2025 15:03
serhiy-storchaka
serhiy-storchaka reviewed Jul 22, 2025
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobolevn
Copy link
Member Author

sobolevn commented Jul 22, 2025 •
edited
Loading

Thanks everyone! Will leave open till tomorrow and merge :)

@sobolevn sobolevn merged commit 99cdf1d into python:main Jul 23, 2025
44 checks passed
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@sobolevn @taegyunkim
pythongh-136437: Make several functions in os.path pos-only (python…
a887e2f 
…#136949)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@sobolevn @Agent-Hellboy
pythongh-136437: Make several functions in os.path pos-only (python…
a577db8 
…#136949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @AA-Turner @serhiy-storchaka