Skip to content

gh-136980: Remove unused C tracing code in bdb #136981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2025
Merged

gh-136980: Remove unused C tracing code in bdb #136981

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8965ff
Remove unused C tracing code in bdb
FredericDT Jul 22, 2025
8bfd968
Remove 'Python' from docs which previously distinguishing from c events
FredericDT Jul 23, 2025
a60511d
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 23, 2025
5800fad
Trim tail space
FredericDT Jul 23, 2025
ad8028f
For inline literals, use double backticks
FredericDT Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Doc/library/bdb.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,8 @@ The :mod:`bdb` module also defines two classes:
entered.
* ``"return"``: A function or other code block is about to return.
* ``"exception"``: An exception has occurred.
* ``"c_call"``: A C function is about to be called.
* ``"c_return"``: A C function has returned.
* ``"c_exception"``: A C function has raised an exception.

For the Python events, specialized functions (see below) are called. For
the C events, no action is taken.
For the Python events, specialized functions (see below) are called.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess Python does not make sense here anymore - it's all the events.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I have them in 8bfd968


The *arg* parameter depends on the previous event.

Expand Down
11 changes: 1 addition & 10 deletions Lib/bdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,9 @@ def trace_dispatch(self, frame, event, arg):
is entered.
return: A function or other code block is about to return.
exception: An exception has occurred.
c_call: A C function is about to be called.
c_return: A C function has returned.
c_exception: A C function has raised an exception.

For the Python events, specialized functions (see the dispatch_*()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we don't need to distinguish Python events anymore.

methods) are called. For the C events, no action is taken.
methods) are called.

The arg parameter depends on the previous event.
"""
Expand All @@ -288,12 +285,6 @@ def trace_dispatch(self, frame, event, arg):
return self.dispatch_return(frame, arg)
if event == 'exception':
return self.dispatch_exception(frame, arg)
if event == 'c_call':
return self.trace_dispatch
if event == 'c_exception':
return self.trace_dispatch
if event == 'c_return':
return self.trace_dispatch
if event == 'opcode':
return self.dispatch_opcode(frame, arg)
print('bdb.Bdb.dispatch: unknown debugging event:', repr(event))
Expand Down
Loading