Skip to content

gh-133296: Fix versionadded for C API functions that were backported #137024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

gh-133296: Fix versionadded for C API functions that were backported #137024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Doc/c-api/init.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2287,7 +2287,7 @@ The C-API provides a basic mutual exclusion lock.
should not be used to make concurrency control decisions, as the lock
state may change immediately after the check.

.. versionadded:: next
.. versionadded:: 3.14

.. _python-critical-section-api:

Expand Down Expand Up @@ -2372,7 +2372,7 @@ code triggered by the finalizer blocks and calls :c:func:`PyEval_SaveThread`.

On the default build, this macro expands to ``{``.

.. versionadded:: next
.. versionadded:: 3.14

.. c:macro:: Py_END_CRITICAL_SECTION()

Expand Down Expand Up @@ -2418,7 +2418,7 @@ code triggered by the finalizer blocks and calls :c:func:`PyEval_SaveThread`.

On the default build, this macro expands to ``{``.

.. versionadded:: next
.. versionadded:: 3.14

.. c:macro:: Py_END_CRITICAL_SECTION2()

Expand Down
1 change: 1 addition & 0 deletions Doc/whatsnew/3.14.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3035,6 +3035,7 @@ Porting to Python 3.14
* ``_Py_GetConfig()``: :c:func:`PyConfig_Get` and :c:func:`PyConfig_GetInt`
* ``_Py_HashBytes()``: :c:func:`Py_HashBuffer`
* ``_Py_fopen_obj()``: :c:func:`Py_fopen`
* ``PyMutex_IsLocked()`` : :c:func:`PyMutex_IsLocked`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the first one start with an underscore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the private API lacked a leading underscore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I need to undo my typo "fix" :)

#137525


The `pythoncapi-compat project`_ can be used to get most of these new
functions on Python 3.13 and older.
Expand Down
2 changes: 0 additions & 2 deletions Doc/whatsnew/3.15.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,8 +504,6 @@ Porting to Python 3.15

* Private functions promoted to public C APIs:

* ``PyMutex_IsLocked()`` : :c:func:`PyMutex_IsLocked`

The |pythoncapi_compat_project| can be used to get most of these new
functions on Python 3.14 and older.

Expand Down
Loading