Touch up Setup.local handling in Tools/wasm/wasi
#137051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment in the generated file is more self-explanatory. The checks for unexpected file contents are also strengthened.
brettcannon
added
skip issue
skip news
OS-wasi
needs backport to 3.14
|
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 23, 2025
The comment in the generated file is now more self-explanatory. The checks for unexpected file contents are also strengthened. (cherry picked from commit ec7fad7) Co-authored-by: Brett Cannon <[email protected]>
|
GH-137053 is a backport of this pull request to the 3.14 branch. |
|
I guess I should apply the same change to |
@hoodmane Eh, it's up to you. I mostly did it because I was already touching the code to update the comment and checked that the file is, in fact, still necessary. The changes are rather minor and if I wasn't already updating the comment I probably would not have bothered. |
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
The comment in the generated file is now more self-explanatory. The checks for unexpected file contents are also strengthened.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
The comment in the generated file is now more self-explanatory. The checks for unexpected file contents are also strengthened.
brettcannon
added a commit
that referenced
this pull request
Oct 7, 2025
… (GH-137053) Touch up `Setup.local` handling in `Tools/wasm/wasi` (GH-137051) The comment in the generated file is now more self-explanatory. The checks for unexpected file contents are also strengthened. (cherry picked from commit ec7fad7) Co-authored-by: Brett Cannon <[email protected]> Co-authored-by: Zachary Ware <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the generated file is now more self-explanatory. The checks for unexpected file contents are also strengthened.