Suggested Improvements per PEP 7 - Style Guide for C Code #137087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e comments, comment text, and additional const and functions.
…d /* and */ on own line) and code structure spacing for conditionals per PEP 7 - C Style. Removed additional leading "*" characters in multi-line comments. Consider further addresing redundant parens in return statements per PEP 7, though some may be best for visual grouping.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Hello, thanks for your contribution, however we do not accept such cosmetic changes. |
quantypi
changed the title
|
@StanFromIreland, thank you for the quick reply. I adjusted my title/comments with more detail. Trying to get accustomed to the workflow here so wanted to start with some simple cleanup. There are many instances of trailing whitespace in violation of PEP 7, for example, are these all to be ignored? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multi-line left-aligned comment: /* and / on own line with no leading or trailing whitespace, respectively.
embedded (non left-aligned) comments: / and / share line with first and last line of comment, respectively.
all comments: leading "" removed for body of comment to match style majority of codebase.
Removed duplicate newlines.
Removed trailing whitespace.
Replaced tabs with spaces in all instances.
Fixed conditionals with spacing in parens.
Fixed redundant parens in return. Note that additional redundant parens exist but may be best for visual clarity (e.g. grouping expressions within a return expression to visually isolate from logical operators like ||).