- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
          gh-81719: Add private members to zipfile.ZipFile to make it easier to subclass
          #137101
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            adiroiban
  wants to merge
  13
  commits into
  python:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
chevah:81719-zipfile-refactor-for-subclass
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +151
        
        
          −16
        
        
          
        
      
    
  
  
     Open
                    Changes from 2 commits
      Commits
    
    
            Show all changes
          
          
            13 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      54b7e31
              
                Add private members via init to make it easier to subclass.
              
              
                adiroiban 609d44f
              
                Apply suggestions from code review
              
              
                adiroiban a6d22b7
              
                Update after review.
              
              
                 36defbc
              
                Add tests.
              
              
                 a3be112
              
                Add what's new and fix sphinx lint.
              
              
                 2c998fb
              
                Fix docstring.
              
              
                 63856e8
              
                Update tests
              
              
                 d7baea1
              
                Add documentation
              
              
                 83e7979
              
                Update after review from Brian
              
              
                 7ac534a
              
                Another feedback from Brian.
              
              
                 7be0dab
              
                Merge branch 'main' into 81719-zipfile-refactor-for-subclass
              
              
                adiroiban b5edb6f
              
                Merge branch 'main' into 81719-zipfile-refactor-for-subclass
              
              
                adiroiban 54e6384
              
                Merge branch 'main' into 81719-zipfile-refactor-for-subclass
              
              
                adiroiban File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            2 changes: 2 additions & 0 deletions
          
          2 
        
  Misc/NEWS.d/next/Library/2025-07-25-14-27-29.gh-issue-81719.hWp7Mn.rst
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| zipfile.ZipFile.__init__ was updated to make it easier to subclass and | ||
| extend it to support new encryption methods. | ||
|         
                  adiroiban marked this conversation as resolved.
              Outdated
          
            Show resolved
            Hide resolved | ||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.