Skip to content

gh-137293: Ignore Exceptions when searching ELF File in Remote Debug #137309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-137293: Ignore Exceptions when searching ELF File in Remote Debug #137309

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
18786cf
gh-137293: Print Exceptions in searching ELF File in Remote Debug
uxioandrade Aug 1, 2025
fc3649c
gh-137293 print exception instead of clearing
uxioandrade Aug 1, 2025
8086288
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 1, 2025
17b9d10
gh-137293 clear exception
uxioandrade Aug 1, 2025
86e73eb
gh-137293 remove exceptions in search_elf_file_for_section
uxioandrade Aug 1, 2025
c6b5c64
Update Misc/NEWS.d/next/Core_and_Builtins/2025-08-01-20-31-30.gh-issu…
uxioandrade Aug 1, 2025
110d7d7
gh-137293 Clear exceptions before search_elf_file_for_section
uxioandrade Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-08-01-20-31-30.gh-issue-137293.4x3JbV.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ignore Exceptions when searching ELF Files in remote debug since the file containing PyRuntime is the only one that matters.
18 changes: 0 additions & 18 deletions Python/remote_debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,35 +572,23 @@ search_elf_file_for_section(

int fd = open(elf_file, O_RDONLY);
if (fd < 0) {
PyErr_Format(PyExc_OSError,
"Cannot open ELF file '%s' for section '%s' search: %s",
elf_file, secname, strerror(errno));
goto exit;
}

struct stat file_stats;
if (fstat(fd, &file_stats) != 0) {
PyErr_Format(PyExc_OSError,
"Cannot get file size for ELF file '%s' during section '%s' search: %s",
elf_file, secname, strerror(errno));
goto exit;
}

file_memory = mmap(NULL, file_stats.st_size, PROT_READ, MAP_PRIVATE, fd, 0);
if (file_memory == MAP_FAILED) {
PyErr_Format(PyExc_OSError,
"Cannot memory map ELF file '%s' (size: %lld bytes) for section '%s' search: %s",
elf_file, (long long)file_stats.st_size, secname, strerror(errno));
goto exit;
}

Elf_Ehdr* elf_header = (Elf_Ehdr*)file_memory;

// Validate ELF header
if (elf_header->e_shstrndx >= elf_header->e_shnum) {
PyErr_Format(PyExc_RuntimeError,
"Invalid ELF file '%s': string table index %u >= section count %u",
elf_file, elf_header->e_shstrndx, elf_header->e_shnum);
goto exit;
}

Expand Down Expand Up @@ -635,9 +623,6 @@ search_elf_file_for_section(
}

if (first_load_segment == NULL) {
PyErr_Format(PyExc_RuntimeError,
"No PT_LOAD segment found in ELF file '%s' (%u program headers examined)",
elf_file, elf_header->e_phnum);
goto exit;
}

Expand All @@ -650,9 +635,6 @@ search_elf_file_for_section(
munmap(file_memory, file_stats.st_size);
}
if (fd >= 0 && close(fd) != 0) {
PyErr_Format(PyExc_OSError,
"Failed to close ELF file '%s': %s",
elf_file, strerror(errno));
result = 0;
}
return result;
Expand Down
Loading