Skip to content

gh-137293: Ignore Exceptions when searching ELF File in Remote Debug #137309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-137293: Ignore Exceptions when searching ELF File in Remote Debug #137309

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
18786cf
gh-137293: Print Exceptions in searching ELF File in Remote Debug
uxioandrade Aug 1, 2025
fc3649c
gh-137293 print exception instead of clearing
uxioandrade Aug 1, 2025
8086288
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 1, 2025
17b9d10
gh-137293 clear exception
uxioandrade Aug 1, 2025
86e73eb
gh-137293 remove exceptions in search_elf_file_for_section
uxioandrade Aug 1, 2025
c6b5c64
Update Misc/NEWS.d/next/Core_and_Builtins/2025-08-01-20-31-30.gh-issu…
uxioandrade Aug 1, 2025
110d7d7
gh-137293 Clear exceptions before search_elf_file_for_section
uxioandrade Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Python/remote_debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,9 @@ search_linux_map_for_section(proc_handle_t *handle, const char* secname, const c
if (retval) {
break;
}
if (PyErr_Occurred()){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, this should always be true at this point. If search_elf_file_for_section returns 0, there's an exception set.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be overly defensive but could there be no exceptions in case section is null here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have argued that was its own issue, but per discussion it seems we should just remove exceptions from search_elf_file_for_section entirely. It's not called anywhere else.

PyErr_Print();
}
}
}

Expand Down
Loading