Skip to content

gh-137335: Remove use of mktemp() in asyncio.windows_utils #137333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

gh-137335: Remove use of mktemp() in asyncio.windows_utils #137333

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a8fff9e
Deprecate mktemp() to use a safer function.
lighting9999 Aug 3, 2025
cf5da77
fix windows_utils.py
lighting9999 Aug 3, 2025
345f5e7
fix windows_utils.py
lighting9999 Aug 3, 2025
33caf80
change at tempfile.mkstemp() instead of tempfile.mktemp()
lighting9999 Aug 3, 2025
2381537
Merge branch 'main' into path-1
lighting9999 Aug 3, 2025
daec027
fix windows_utils.py
lighting9999 Aug 3, 2025
7b2811a
Update windows_utils.py
lighting9999 Aug 4, 2025
31bdba4
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/asyncio/windows_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import subprocess
import tempfile
import warnings
import uuid


__all__ = 'pipe', 'Popen', 'PIPE', 'PipeHandle'
Expand All @@ -31,9 +32,8 @@

def pipe(*, duplex=False, overlapped=(True, True), bufsize=BUFSIZE):
"""Like os.pipe() but with overlapped support and using handles not fds."""
address = tempfile.mktemp(
prefix=r'\\.\pipe\python-pipe-{:d}-{:d}-'.format(
os.getpid(), next(_mmap_counter)))
pipename = f'python-pipe-{os.getpid()}-{uuid.uuid4()}'
address = fr'\\.\pipe\{pipename}'

if duplex:
openmode = _winapi.PIPE_ACCESS_DUPLEX
Expand Down
Loading