Skip to content

GH-116380: Speed up glob.[i]glob() by making fewer system calls (take 2) #137474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

GH-116380: Speed up glob.[i]glob() by making fewer system calls (take 2) #137474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
74aed76
GH-116380: Speed up `glob.[i]glob()` by making fewer system calls (ta…
barneygale Aug 6, 2025
7cc555f
Fix version number
barneygale Aug 6, 2025
51515ce
Apply suggestions from code review
barneygale Aug 6, 2025
9843b6a
Address review feedback
barneygale Aug 6, 2025
a116d94
Errant tabs
barneygale Aug 6, 2025
e2bb3cb
Make Globber arguments keyword-only
barneygale Aug 7, 2025
c093c4e
Tweak Globber argument defaults
barneygale Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Doc/library/glob.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ The :mod:`glob` module defines the following functions:
Using the "``**``" pattern in large directory trees may consume
an inordinate amount of time.

.. note::
This function may return duplicate path names if *pathname*
contains multiple "``**``" patterns and *recursive* is true.

.. versionchanged:: 3.5
Support for recursive globs using "``**``".

Expand All @@ -88,6 +84,11 @@ The :mod:`glob` module defines the following functions:
.. versionchanged:: 3.11
Added the *include_hidden* parameter.

.. versionchanged:: next
Matching path names are only returned once. In previous versions, this
function could have returned duplicate path names if *pathname*
contained multiple "``**``" patterns and *recursive* was true.


.. function:: iglob(pathname, *, root_dir=None, dir_fd=None, recursive=False, \
include_hidden=False)
Expand All @@ -98,10 +99,6 @@ The :mod:`glob` module defines the following functions:
.. audit-event:: glob.glob pathname,recursive glob.iglob
.. audit-event:: glob.glob/2 pathname,recursive,root_dir,dir_fd glob.iglob

.. note::
This function may return duplicate path names if *pathname*
contains multiple "``**``" patterns and *recursive* is true.

.. versionchanged:: 3.5
Support for recursive globs using "``**``".

Expand All @@ -111,6 +108,11 @@ The :mod:`glob` module defines the following functions:
.. versionchanged:: 3.11
Added the *include_hidden* parameter.

.. versionchanged:: next
Matching path names are only yielded once. In previous versions, this
function could have returned duplicate path names if *pathname*
contained multiple "``**``" patterns and *recursive* was true.


.. function:: escape(pathname)

Expand Down
8 changes: 8 additions & 0 deletions Doc/whatsnew/3.15.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,14 @@ difflib
(Contributed by Jiahao Li in :gh:`134580`.)


glob
----

* Reduce the number of system calls in :func:`glob.glob` and :func:`~glob.iglob`,
thereby improving the speed of globbing operations by 20-80%.
(Contributed by Barney Gale in :gh:`116380`.)


hashlib
-------

Expand Down
Loading
Loading