Skip to content

gh-135052: Fix bug that XID_Continue Unicode characters in function/class names highlighted incorrectly (colorizer.py) #137612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+14 −3
Open

gh-135052: Fix bug that XID_Continue Unicode characters in function/class names highlighted incorrectly (colorizer.py) #137612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c782fe4
fix(idlelib): fix highlighted error of module `idlelib`
Xiaokang2022 Aug 10, 2025
03ad785
test(colorizer): add some tests for `colorizer.idprog`
Xiaokang2022 Aug 10, 2025
d7c9c07
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 10, 2025
8397792
test(colorizer): fix a test
Xiaokang2022 Aug 10, 2025
ed0c31b
Merge branch 'fix-idle-name-error' of https://github.com/Xiaokang2022…
Xiaokang2022 Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Lib/idlelib/colorizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def make_pat():


prog = make_pat()
idprog = re.compile(r"\s+(\w+)")
idprog = re.compile(r"\s+([^\\\s([:]+)")
prog_group_name_to_tag = {
"MATCH_SOFTKW": "KEYWORD",
"CASE_SOFTKW": "KEYWORD",
Expand Down Expand Up @@ -346,8 +346,9 @@ def _add_tags_in_section(self, chars, head):
self._add_tag(a, b, head, name)
if matched_text in ("def", "class"):
if m1 := self.idprog.match(chars, b):
a, b = m1.span(1)
self._add_tag(a, b, head, "DEFINITION")
if m1.groups()[0].isidentifier():
a, b = m1.span(1)
self._add_tag(a, b, head, "DEFINITION")

def removecolors(self):
"Remove all colorizing tags."
Expand Down
8 changes: 8 additions & 0 deletions Lib/idlelib/idle_test/test_colorizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,14 @@ def test_idprog(self):
self.assertIsNone(m)
m = idprog.match(' space')
self.assertEqual(m.group(0), ' space')
m = idprog.match(' space')
self.assertTrue(m.groups()[0].isidentifier())
m = idprog.match(' 42')
self.assertFalse(m.groups()[0].isidentifier())
m = idprog.match(' dot·[T]')
self.assertTrue(m.groups()[0].isidentifier())
m = idprog.match(' cls()')
self.assertTrue(m.groups()[0].isidentifier())


class ColorConfigTest(unittest.TestCase):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/IDLE/2025-08-10-15-01-48.gh-issue-135052._pUw6u.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix a bug that XID_Continue Unicode characters in function/class names
highlighted incorrectly.
Loading