Skip to content

gh-137562: Fix github-issue number with deallocated objects in cache #137614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

gh-137562: Fix github-issue number with deallocated objects in cache #137614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Python/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,7 @@ move_legacy_finalizer_reachable(PyGC_Head *finalizers)
* to invalidate caches (e.g. by PyType_Modified), that clearing has created
* a bug. If the weakref to the subclass is cleared before a finalizer is
* called, the cache may not be correctly invalidated. That can lead to
* segfaults since the caches can refer to deallocated objects (GH-91636
* segfaults since the caches can refer to deallocated objects (GH-135552
* is an example). Now, we delay the clear of weakrefs without callbacks
* until *after* finalizers have been executed. That means weakrefs without
* callbacks are still usable while finalizers are being executed.
Expand Down
Loading