GH-92266: Remove embedded tabs from c-analyzer/cpython/_parser.py
#137622
+237
−258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
commented
Aug 10, 2025
|
|
||
| # others | ||
| ('Modules/_sre/sre_lib.h', 'LOCAL(type)', 'static inline type'), | ||
| ('Modules/_sre/sre_lib.h', 'SRE(F)', 'sre_ucs2_'), ##F |
There was a problem hiding this comment.
This produces identical output to the current state, due to parsing ##F as a comment, but I think the line should probably read:
Suggested change
| ('Modules/_sre/sre_lib.h', 'SRE(F)', 'sre_ucs2_'), ##F | |
| ('Modules/_sre/sre_lib.h', 'SRE(F)', 'sre_ucs2_##F'), |
AA-Turner
commented
Aug 10, 2025
| # @end=conf@ | ||
| ''') | ||
| EXCLUDED = format_table_lines([ | ||
| # OSX |
There was a problem hiding this comment.
If updating other things:
Suggested change
| # OSX | |
| # macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to avoid some of the problems we've seen with embedded tabs by changing the global variables within
c-analyzer/cpython/_parser.pyto use more structured data.The output is identical, save for
INCL_DIRS, where the fourth line (* ./Include/internal/mimalloc) currently uses spaces instead of tabs, showing that the current format is quite hard to properly keep up to date. The errant line was added in #109914.What do you think @ericsnowcurrently?
See also: