gh-137706: make typing._is_unpacked_typevartuple check for True instead of truthy
#137712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthy output was interpreting annotationlib _Stringifier instances as unpacked TypeVarTuples
DavidCEllis
requested review from
AlexWaygood and
JelleZijlstra
as code owners
|
Could you add a NEWS entry? |
Misc/NEWS.d/next/Library/2025-09-05-21-10-24.gh-issue-137706.0EztiJ.rst
Outdated
Show resolved
Hide resolved
…EztiJ.rst Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Sep 5, 2025
|
Thanks @DavidCEllis for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 6, 2025
…e` instead of truthy (pythonGH-137712) (cherry picked from commit 7e652f4) Co-authored-by: David Ellis <[email protected]>
|
GH-138574 is a backport of this pull request to the 3.14 branch. |
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…e` instead of truthy (python#137712)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #137706 making
Annotated[undefined, '']partially resolvable underFormat.FORWARDREFI hope I put the additional test in a reasonable place. It's a large file!