Skip to content

gh-137728 gh-137762: Fix bugs in the JIT with many local variables #137764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2025
Merged

gh-137728 gh-137762: Fix bugs in the JIT with many local variables #137764

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffb62d9
Fix a bug in the JIT with many local variables
Fidget-Spinner Aug 14, 2025
d33a8d9
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 14, 2025
90e89df
Fix the other thing too
Fidget-Spinner Aug 14, 2025
ad5926e
Update 2025-08-14-14-18-29.gh-issue-137728.HdYS9R.rst
Fidget-Spinner Aug 14, 2025
16bd314
Address review
Fidget-Spinner Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-08-14-14-18-29.gh-issue-137728.HdYS9R.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the JIT's handling of many local variables. This previously caused a segfault.
12 changes: 8 additions & 4 deletions Python/optimizer_analysis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,15 +482,19 @@ optimize_uops(
_PyUOpInstruction *corresponding_check_stack = NULL;

_Py_uop_abstractcontext_init(ctx);

// Note: this must happen before frame_new, as it might override
// the result should frame_new set things to bottom.
ctx->done = false;
ctx->out_of_space = false;
ctx->contradiction = false;

_Py_UOpsAbstractFrame *frame = _Py_uop_frame_new(ctx, co, curr_stacklen, NULL, 0);
if (frame == NULL) {
return -1;
return 0;
}
ctx->curr_frame_depth++;
ctx->frame = frame;
ctx->done = false;
ctx->out_of_space = false;
ctx->contradiction = false;

_PyUOpInstruction *this_instr = NULL;
for (int i = 0; !ctx->done; i++) {
Expand Down
Loading