gh-135852: Add NTEventLog related functions to _winapi #137860
Conversation
|
Sorry, I forgot to check the CI result after the push. |
There was a problem hiding this comment.
Thank you for your PR @aisk. It look interesting.
Could you please show how can this be used in NTEventLogHandler? Maybe not in this PR, but in a separate PR created on top of this?
Modules/_winapi.c
Outdated
| PyObject *item = PyList_GetItem(strings, i); | ||
| if (!PyUnicode_Check(item)) { | ||
| PyMem_Free(string_array); | ||
| PyErr_SetString(PyExc_TypeError, "All strings must be unicode"); |
There was a problem hiding this comment.
"unicode" is a weird term. There is no longer type unicode. I would suggest something like: "expected a list of strings, not %T".
Modules/_winapi.c
Outdated
| // Handle raw data | ||
| if (raw_data->buf != NULL) { | ||
| data = raw_data->buf; | ||
| data_size = (DWORD) raw_data->len; |
There was a problem hiding this comment.
Possible integer overflow.
Co-authored-by: Serhiy Storchaka <[email protected]>
Thanks for the view! I'll create another PR based on this to try to implement the whole feature in the original issue. |
3 participants
Please note that the
lpUserSidparameter in ReportEvent don't added because it needs passing a new struct from Python to it, and we don't need this parameter for the usage of implementNTEventLogHandler. If we want add it in the future, we can add it as kwargs.Docuements for these functions:
logging.handlers.NTEventLogHandler#135852