Skip to content

gh-137829: Fix shelve tests for backend compatibility #137879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+28 −12
Open

gh-137829: Fix shelve tests for backend compatibility #137879

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
306e43d
Fix shelve tests for backend compatibility
furkanonder Aug 17, 2025
79e335e
split incomplete serializer/deserializer in test_shelve
furkanonder Aug 18, 2025
5b9f61b
add a test case for custom serializer that returning wrong type
furkanonder Aug 18, 2025
2e3ea9b
Add comments clarifying exceptions when serializer returns None
furkanonder Aug 29, 2025
e1b0584
Remove test case
furkanonder Aug 30, 2025
f0af214
Add test for invalid custom serializer
furkanonder Sep 8, 2025
e64777b
Add parameterized test for invalid custom serializers
furkanonder Sep 19, 2025
c683173
Remove test_custom_incomplete_serializer
furkanonder Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/test/test_shelve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ def test_custom_serializer_and_deserializer(self):
def serializer(obj, protocol):
if isinstance(obj, (bytes, bytearray, str)):
if protocol == 5:
if isinstance(obj, bytearray):
return bytes(obj)
return obj
return type(obj).__name__
elif isinstance(obj, array.array):
Expand Down Expand Up @@ -223,11 +225,10 @@ def deserializer(data):
)

def test_custom_incomplete_serializer_and_deserializer(self):
dbm_sqlite3 = import_helper.import_module("dbm.sqlite3")
os.mkdir(self.dirname)
self.addCleanup(os_helper.rmtree, self.dirname)

with self.assertRaises(dbm_sqlite3.error):
with self.assertRaises((TypeError, dbm.error)):
def serializer(obj, protocol=None):
pass

Expand Down
Loading