Skip to content

gh-128042: configure warns when CFLAGS=-O0 and --enable-optimizations #137975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 26, 2025
Merged

gh-128042: configure warns when CFLAGS=-O0 and --enable-optimizations #137975

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4a196c4
gh-128042: `configure` complains when CFLAGS=-O0 and --enable-optimiz…
taegyunkim Aug 20, 2025
f8d75ce
Warn instead of error
taegyunkim Aug 20, 2025
a3db02c
Merge branch 'main' into configure-pgo-O0
taegyunkim Aug 20, 2025
69d1659
Update configure.ac
taegyunkim Aug 26, 2025
783700d
Merge branch 'main' into configure-pgo-O0
taegyunkim Aug 26, 2025
75d8d67
update configure
taegyunkim Aug 26, 2025
634a247
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 26, 2025
d9d7514
use m4_normalize for multiline message
taegyunkim Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2025-08-26-21-18-32.gh-issue-128042.5voC8H.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
``./configure`` now warns when ``--enable-optimizations`` and ``CFLAGS=-O0`` are both set, suggesting removing ``-O0`` from ``CFLAGS`` for optimal performance. Patch by Taegyun Kim.
11 changes: 11 additions & 0 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1823,6 +1823,14 @@ fi],
[AC_MSG_RESULT([no])])

if test "$Py_OPT" = 'true' ; then
# Check for conflicting CFLAGS=-O0 and --enable-optimizations
case "$CFLAGS" in
*-O0*)
AC_MSG_WARN([CFLAGS contains -O0 which may conflict with \
--enable-optimizations. Consider removing -O0 from CFLAGS \
for optimal performance.])
;;
esac
# Intentionally not forcing Py_LTO='true' here. Too many toolchains do not
# compile working code using it and both test_distutils and test_gdb are
# broken when you do manage to get a toolchain that works with it. People
Expand Down
Loading